[tools] DON'T REVIEW IT: track comments left by alan
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jun 5, 2025, 8:54:25 PM (3 days ago) Jun 5
to Xie Yuchen, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Findley, Go LUCI, Alan Donovan, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/protocol: refine DocumentURI Clean method and its usages
This CL tracks the comments left by Alan Donovan in CL663295, thanks again.
* change protocol.Clean function to DocumentURI method
* ensure the same key when access and operate viewMap
* factor some logics
Change-Id: Ib717705495997379ed0f872d438f238ca1308a23
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Robert Findley <rfin...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M gopls/internal/cache/session.go
- M gopls/internal/protocol/uri.go
- M gopls/internal/test/integration/fake/editor.go
Change size: S
Delta: 3 files changed, 18 insertions(+), 20 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Robert Findley, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages