[benchmarks] sweet: upgrade cockroachdb to v25.2.0 and re-enable

1 view
Skip to first unread message

Michael Knyszek (Gerrit)

unread,
Jun 7, 2025, 6:21:26 AM (2 days ago) Jun 7
to goph...@pubsubhelper.golang.org, Carlos Amedee, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Michael Pratt

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Michael Knyszek . resolved

in a gomote, it does actually seem to work now? maybe it's a fluke, but I've run the integration test and also just the benchmark directly at least a couple dozen times. I'll keep trying though.

Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: I5153f428037813e80c4eefca563f95cbb500938a
Gerrit-Change-Number: 679755
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Carlos Amedee <car...@golang.org>
Gerrit-Comment-Date: Sat, 07 Jun 2025 03:21:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Carlos Amedee (Gerrit)

unread,
Jun 7, 2025, 6:57:58 AM (2 days ago) Jun 7
to Michael Knyszek, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Michael Pratt

Carlos Amedee voted and added 1 comment

Votes added by Carlos Amedee

Code-Review+2

1 comment

Patchset-level comments
Carlos Amedee . resolved

Let's give it a try.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: I5153f428037813e80c4eefca563f95cbb500938a
Gerrit-Change-Number: 679755
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Sat, 07 Jun 2025 03:57:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
Jun 7, 2025, 7:09:22 AM (2 days ago) Jun 7
to Michael Knyszek, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Carlos Amedee, Michael Pratt, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
sweet: upgrade cockroachdb to v25.2.0 and re-enable

This is a new release. It looks OK to me locally, so perhaps whatever
was ailing us is now gone. I hope. Famous last words but, it's a flaky
failure, so I think we might just have to try.

Fixes golang/go#73474.
Change-Id: I5153f428037813e80c4eefca563f95cbb500938a
Reviewed-by: Carlos Amedee <car...@golang.org>
Auto-Submit: Michael Knyszek <mkny...@google.com>
Files:
  • M sweet/cmd/sweet/benchmark.go
  • M sweet/harnesses/cockroachdb.go
Change size: XS
Delta: 2 files changed, 2 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: I5153f428037813e80c4eefca563f95cbb500938a
Gerrit-Change-Number: 679755
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages