[go] runtime: yield in TestSynctest to ensure cleanups run

2 views
Skip to first unread message

Damien Neil (Gerrit)

unread,
Jun 7, 2025, 12:23:24 AM (9 days ago) Jun 7
to goph...@pubsubhelper.golang.org, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f18d74d6fccf2c5a9222317977c7458d67f158
Gerrit-Change-Number: 679696
Gerrit-PatchSet: 6
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Fri, 06 Jun 2025 23:23:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Jun 7, 2025, 4:18:51 AM (9 days ago) Jun 7
to Damien Neil, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Damien Neil

Michael Knyszek voted and added 1 comment

Votes added by Michael Knyszek

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Michael Knyszek . resolved

sigh... yet again, the same footgun...

Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f18d74d6fccf2c5a9222317977c7458d67f158
Gerrit-Change-Number: 679696
Gerrit-PatchSet: 6
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Sat, 07 Jun 2025 03:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Damien Neil (Gerrit)

unread,
Jun 9, 2025, 7:15:08 PM (7 days ago) Jun 9
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com

Damien Neil submitted the change

Change information

Commit message:
runtime: use small struct TestSynctest to ensure cleanups run

Finalizers and cleanup funcs weren't running on the windows-arm64
builder. Put finalizers/cleanups on a small struct containing a pointer
rather than an *int, which fixes the problem.

Also uncomment a synctest.Wait that was accidentally commented out.

Fixes #73977
Change-Id: Ia6f18d74d6fccf2c5a9222317977c7458d67f158
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
  • M src/runtime/testdata/testsynctest/main.go
Change size: S
Delta: 1 file changed, 20 insertions(+), 14 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ia6f18d74d6fccf2c5a9222317977c7458d67f158
Gerrit-Change-Number: 679696
Gerrit-PatchSet: 7
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages