Search

Clear search

Close search

Main menu

Google apps

golang-codereviews

Contact owners and managers

1–30 of 103072

0 selected

Jonathan Amsterdam (Gerrit)

6:52 AM

[tools] internal/mcp: fix prompt example

Attention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change

unread,

[tools] internal/mcp: fix prompt example

Attention needed from Robert Findley and Sam Thanawalla Jonathan Amsterdam has uploaded the change

6:52 AM

Robert Findley (Gerrit), Jonathan Amsterdam (Gerrit)2

6:33 AM

[tools] internal/mcp/cmd/toolgen: add a command to generate tools

Attention needed from Hyang-Ah Hana Kim and Robert Findley Jonathan Amsterdam added 1 comment

unread,

[tools] internal/mcp/cmd/toolgen: add a command to generate tools

Attention needed from Hyang-Ah Hana Kim and Robert Findley Jonathan Amsterdam added 1 comment

6:33 AM

Robert Findley (Gerrit)

5:44 AM

[tools] internal/mcp: update protocol versions

Robert Findley has uploaded the change for review Commit message internal/mcp: update protocol

unread,

[tools] internal/mcp: update protocol versions

Robert Findley has uploaded the change for review Commit message internal/mcp: update protocol

5:44 AM

Robert Findley (Gerrit)3

5:20 AM

[tools] internal/mcp: customizable event persistence

Attention needed from Jonathan Amsterdam Robert Findley added 1 comment Patchset-level comments File-

unread,

[tools] internal/mcp: customizable event persistence

Attention needed from Jonathan Amsterdam Robert Findley added 1 comment Patchset-level comments File-

5:20 AM

shuang cui (Gerrit), … Michael Knyszek (Gerrit)9

4:01 AM

[go] runtime: fix struct comment

Attention needed from Michael Knyszek shuang cui added 1 comment File src/runtime/mheap.go Line 317,

unread,

[go] runtime: fix struct comment

Attention needed from Michael Knyszek shuang cui added 1 comment File src/runtime/mheap.go Line 317,

4:01 AM

Alan Donovan (Gerrit), Robert Findley (Gerrit)12

4:00 AM

[tools] gopls/internal/analysis/unusedfunc: support var, type, func

Alan Donovan submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved

unread,

[tools] gopls/internal/analysis/unusedfunc: support var, type, func

Alan Donovan submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved

4:00 AM

Julian Zhu (Gerrit), Keith Randall (Gerrit)5

3:56 AM

[go] runtime: optimize memclr on mips64x

Julian Zhu added 1 comment File src/runtime/memclr_mips64x.s Line 71, Patchset 1 (Parent): no_msa:

unread,

[go] runtime: optimize memclr on mips64x

Julian Zhu added 1 comment File src/runtime/memclr_mips64x.s Line 71, Patchset 1 (Parent): no_msa:

3:56 AM

Michael Knyszek (Gerrit), … Cherry Mui (Gerrit)4

3:50 AM

[go] runtime: prevent mutual deadlock between GC stopTheWorld and suspendG

Attention needed from Michael Knyszek and Michael Pratt Cherry Mui voted and added 2 comments Votes

unread,

[go] runtime: prevent mutual deadlock between GC stopTheWorld and suspendG

Attention needed from Michael Knyszek and Michael Pratt Cherry Mui voted and added 2 comments Votes

3:50 AM

abner chenc (Gerrit), … Cherry Mui (Gerrit)12

3:36 AM

[website] _content/doc/go1.25: add release note for loong64

abner chenc submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[website] _content/doc/go1.25: add release note for loong64

abner chenc submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

3:36 AM

sophie zhao (Gerrit)

3:23 AM

[go] cmd/compile: fold negation into multiplication on loong64

sophie zhao has uploaded the change for review Commit message cmd/compile: fold negation into

unread,

[go] cmd/compile: fold negation into multiplication on loong64

sophie zhao has uploaded the change for review Commit message cmd/compile: fold negation into

3:23 AM

Junyang Shao (Gerrit), David Chase (Gerrit)6

3:03 AM

[go/dev.simd] [dev.simd] cmd/compile: fix signature error of PairDotProdAccumulate.

Junyang Shao submitted the change Change information Commit message: [dev.simd] cmd/compile: fix

unread,

[go/dev.simd] [dev.simd] cmd/compile: fix signature error of PairDotProdAccumulate.

Junyang Shao submitted the change Change information Commit message: [dev.simd] cmd/compile: fix

3:03 AM

Dimitri John Ledkov (Gerrit), David Benjamin (Gerrit)3

2:36 AM

[go] crypto/internal/boring: upgrade module to fips-2023042800 / CMVP #4953

Attention needed from Adam Langley, Daniel McCarney, Filippo Valsorda and Roland Shoemaker Dimitri

unread,

[go] crypto/internal/boring: upgrade module to fips-2023042800 / CMVP #4953

Attention needed from Adam Langley, Daniel McCarney, Filippo Valsorda and Roland Shoemaker Dimitri

2:36 AM

Hongxiang Jiang (Gerrit)9

2:28 AM

[tools] gopls/internal/mcp: add diagnositc tool

Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools] gopls/internal/mcp: add diagnositc tool

Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

2:28 AM

Robert Findley (Gerrit), Jonathan Amsterdam (Gerrit)5

1:55 AM

[tools] internal/mcp: rename Stream->Connection

Robert Findley submitted the change with unreviewed changes Unreviewed changes 2 is the latest

unread,

[tools] internal/mcp: rename Stream->Connection

Robert Findley submitted the change with unreviewed changes Unreviewed changes 2 is the latest

1:55 AM

Robert Findley (Gerrit), Jonathan Amsterdam (Gerrit)6

1:55 AM

[tools] internal/mcp: renam NewXXX->NewServerXXX

Robert Findley submitted the change with unreviewed changes Unreviewed changes 2 is the latest

unread,

[tools] internal/mcp: renam NewXXX->NewServerXXX

Robert Findley submitted the change with unreviewed changes Unreviewed changes 2 is the latest

1:55 AM

Robert Findley (Gerrit), … Jonathan Amsterdam (Gerrit)16

1:54 AM

[tools] internal/mcp: support streamable MCP transport

Robert Findley submitted the change with unreviewed changes Unreviewed changes 18 is the latest

unread,

[tools] internal/mcp: support streamable MCP transport

Robert Findley submitted the change with unreviewed changes Unreviewed changes 18 is the latest

1:54 AM

Robert Griesemer (Gerrit)2

1:18 AM

[go] go/types, types2: better error messages for certain type mismatches

Attention needed from Mark Freeman Robert Griesemer voted Auto-Submit +1 Code-Review +1 Commit-Queue

unread,

[go] go/types, types2: better error messages for certain type mismatches

Attention needed from Mark Freeman Robert Griesemer voted Auto-Submit +1 Code-Review +1 Commit-Queue

1:18 AM

Keith Randall (Gerrit), Robert Griesemer (Gerrit)3

12:45 AM

[go] cmd/api: rerun updategolden

Attention needed from Keith Randall Keith Randall voted Auto-Submit +1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/api: rerun updategolden

Attention needed from Keith Randall Keith Randall voted Auto-Submit +1 Code-Review +1 Open in Gerrit

12:45 AM

Kiran M Vijay IBM (Gerrit), … Michael Munday (Gerrit)25

12:34 AM

[go] asm: Adding MVCLE Instruction into asm for s390x

Attention needed from Bill O'Farrell, Ilya Leoshkevich, Kiran M Vijay IBM and Srinivas Pokala

unread,

[go] asm: Adding MVCLE Instruction into asm for s390x

Attention needed from Bill O'Farrell, Ilya Leoshkevich, Kiran M Vijay IBM and Srinivas Pokala

12:34 AM

Charlie Vieth (Gerrit), Robert Griesemer (Gerrit)3

12:28 AM

[go] strings: change IndexAny to search for chars in s when s is large

Attention needed from Charlie Vieth and Robert Griesemer Robert Griesemer added 6 comments Commit

unread,

[go] strings: change IndexAny to search for chars in s when s is large

Attention needed from Charlie Vieth and Robert Griesemer Robert Griesemer added 6 comments Commit

12:28 AM

Hongxiang Jiang (Gerrit)

Jun 17

[tools] internal/mcp: toolgen

Hongxiang Jiang has uploaded the change for review Commit message internal/mcp: toolgen Change-Id:

unread,

[tools] internal/mcp: toolgen

Hongxiang Jiang has uploaded the change for review Commit message internal/mcp: toolgen Change-Id:

Jun 17

Mark Freeman (Gerrit), Robert Griesemer (Gerrit)7

Jun 17

[go] cmd/compile/internal/noder: document dictionary section

Attention needed from Mark Freeman Robert Griesemer voted and added 1 comment Votes added by Robert

unread,

[go] cmd/compile/internal/noder: document dictionary section

Attention needed from Mark Freeman Robert Griesemer voted and added 1 comment Votes added by Robert

Jun 17

Cherry Mui (Gerrit), … Dmitri Shuralyov (Gerrit)18

Jun 17

[build/luci-config] main.star: add dev.simd branch

Attention needed from Cherry Mui and Michael Knyszek Dmitri Shuralyov added 1 comment File main.star

unread,

[build/luci-config] main.star: add dev.simd branch

Attention needed from Cherry Mui and Michael Knyszek Dmitri Shuralyov added 1 comment File main.star

Jun 17

Kevin Burke (Gerrit), … Sean Liao (Gerrit)8

Jun 17

[go] encoding/json/jsontext: fix spelling error

Sean Liao submitted the change Change information Commit message: encoding/json/jsontext: fix

unread,

[go] encoding/json/jsontext: fix spelling error

Sean Liao submitted the change Change information Commit message: encoding/json/jsontext: fix

Jun 17

Junyang Shao (Gerrit), David Chase (Gerrit)2

Jun 17

[arch] internal/simdgen: remove redundant shapes of fused mul/add/sub.

Attention needed from Cherry Mui and Junyang Shao David Chase voted and added 1 comment Votes added

unread,

[arch] internal/simdgen: remove redundant shapes of fused mul/add/sub.

Attention needed from Cherry Mui and Junyang Shao David Chase voted and added 1 comment Votes added

Jun 17

David Chase (Gerrit), Junyang Shao (Gerrit)6

Jun 17

[arch] internal/simdgen: use go/format on generated Go

David Chase submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[arch] internal/simdgen: use go/format on generated Go

David Chase submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Jun 17

Adam Bender (Gerrit), Robert Griesemer (Gerrit)6

Jun 17

[go] go/doc: add a golden test that reproduces #62640

Attention needed from Adam Bender, Jonathan Amsterdam and Robert Griesemer Robert Griesemer voted

unread,

[go] go/doc: add a golden test that reproduces #62640

Attention needed from Adam Bender, Jonathan Amsterdam and Robert Griesemer Robert Griesemer voted

Jun 17

Keith Randall (Gerrit), David Chase (Gerrit)5

Jun 17

[go] cmd/compile: fix containsUnavoidableCall computation

Attention needed from David Chase and Keith Randall Keith Randall voted Auto-Submit+1 Auto-Submit +1

unread,

[go] cmd/compile: fix containsUnavoidableCall computation

Attention needed from David Chase and Keith Randall Keith Randall voted Auto-Submit+1 Auto-Submit +1

Jun 17

Daniel Morsing (Gerrit), Keith Randall (Gerrit)5

Jun 17

[go] cmd/compile/ssa: add uncleared versions of allocators

Attention needed from Daniel Morsing and Martin Möhrmann Keith Randall added 1 comment Patchset-level

unread,

[go] cmd/compile/ssa: add uncleared versions of allocators

Attention needed from Daniel Morsing and Martin Möhrmann Keith Randall added 1 comment Patchset-level

Jun 17

Mark Freeman (Gerrit), Robert Griesemer (Gerrit)7

Jun 17

[go] cmd/compile/internal/types2: add loaded state between loader calls and constraint expansion

Attention needed from Mark Freeman Robert Griesemer added 1 comment Patchset-level comments File-

unread,

[go] cmd/compile/internal/types2: add loaded state between loader calls and constraint expansion

Attention needed from Mark Freeman Robert Griesemer added 1 comment Patchset-level comments File-

Jun 17